Error handing and execution issue fixed

Change-Id: I1baf986dc43eafea7a1fb1276dd6716c19bd96ce

diff --git a/ocd/infra/playbooks/roles/helm/tasks/install.yml b/ocd/infra/playbooks/roles/helm/tasks/install.yml
index a138b32..38ac89a 100644 (file)
--- a/ocd/infra/playbooks/roles/helm/tasks/install.yml
+++ b/ocd/infra/playbooks/roles/helm/tasks/install.yml
@@ -16,7 +16,15 @@
 - name: check whether helm is already installed
   command: which helm
   register: result
-  ignore_errors: 'True'
+  failed_when: false
+  no_log: True
+
+- debug:
+    msg: Helm is already present
+  when: result.rc == 0
+
+- meta: end_play
+  when: result.rc == 0
 
 - name: "Helm download command on x86_64"
   command: wget https://get.helm.sh/helm-v3.0.2-linux-amd64.tar.gz

diff --git a/ocd/infra/playbooks/roles/helm/tasks/uninstall.yml b/ocd/infra/playbooks/roles/helm/tasks/uninstall.yml
index 979df7e..3750518 100644 (file)
--- a/ocd/infra/playbooks/roles/helm/tasks/uninstall.yml
+++ b/ocd/infra/playbooks/roles/helm/tasks/uninstall.yml
@@ -16,7 +16,15 @@
 - name: check whether helm is installed before deleting
   command: which helm
   register: result
-  ignore_errors: 'True'
+  failed_when: false
+  no_log: True
+
+- debug:
+   msg: Helm is not present
+  when: result.rc == 2
+
+- meta: end_play
+  when: result.rc == 2
 
 - name: Helm Uninstall on x86_64
   command: rm -rf linux-amd64/helm