From 0ece91966b5548ae0c8acb3dd8e3ccad94a82fd0 Mon Sep 17 00:00:00 2001 From: Andrew Grimberg Date: Thu, 29 Jun 2023 10:46:58 -0700 Subject: [PATCH] Feat: Switch to submission rules Signed-off-by: Andrew Grimberg --- project.config | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/project.config b/project.config index 523ef3a..752b52c 100644 --- a/project.config +++ b/project.config @@ -48,14 +48,18 @@ createSignedTag = group Administrators createSignedTag = group Project Owners [label "Verified"] - function = MaxWithBlock + function = NoBlock value = -1 Fails value = 0 No score value = +1 Verified defaultValue = 0 copyCondition = changekind:NO_CHANGE +[submit-requirement "Verified"] + description = A maximum 'Verified' vote is required for the 'Verified' label. A minimum vote is blocking. + submittableIf = label:Verified=MAX AND -label:Verified=MIN + canOverrideInChildProjects = false [label "Code-Review"] - function = MaxWithBlock + function = NoBlock defaultValue = 0 value = -2 This shall not be merged value = -1 I would prefer this is not merged as is @@ -63,6 +67,11 @@ value = +1 Looks good to me, but someone else must approve value = +2 Looks good to me, approved copyCondition = changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN +[submit-requirement "Code-Review"] + description = A maximum vote is required for the 'Code-Review' label. \ + A minumum vote is blocking. + submittableIf = label:Code-Review=MAX AND -label:Code-Review=MIN + canOverrideInChildProjects = true [capability] accessDatabase = group Administrators administrateServer = group Administrators -- 2.16.6