From 2f7aee9a93792b1f8a2e3f34b5bf7ee3e9d7f048 Mon Sep 17 00:00:00 2001
From: khemendra kumar <khemendra.kumar@huawei.com>
Date: Tue, 1 Dec 2020 23:16:57 +0530
Subject: [PATCH] Added Input para validation

Signed-off-by: khemendra kumar <khemendra.kumar@huawei.com>
Change-Id: I60eed0dfcaa33bbf9d536f58d60b1d4e76fd82db
---
 .../aPaaS/Obj_Detection_service/configs/start.sh   | 37 ++++++++++++++++++++--
 1 file changed, 34 insertions(+), 3 deletions(-)

diff --git a/example-apps/ROBO/aPaaS/Obj_Detection_service/configs/start.sh b/example-apps/ROBO/aPaaS/Obj_Detection_service/configs/start.sh
index ec14d8d..de45014 100644
--- a/example-apps/ROBO/aPaaS/Obj_Detection_service/configs/start.sh
+++ b/example-apps/ROBO/aPaaS/Obj_Detection_service/configs/start.sh
@@ -16,17 +16,48 @@
 # Validates if ip is valid
 validate_ip()
 {
+ ip_var="$1"
+    # checks if variable is unset
+ if [ -z "$ip_var" ] ; then
+    echo "ip is not set"
+    return 1
+ fi
 
-
+ if ! echo "$ip_var" | grep -qE '^(([0-9]|[1-9][0-9]|1[0-9]{2}|2[0-4][0-9]|25[0-5])\.)' ; then
+   return 1
+ fi
+ return 0
 }
 
 validate_name() {
-
+  hostname="$1"
+  len="${#hostname}"
+  if [ "${len}" -gt "64" ]; then
+    return 1
+  fi
+  if ! echo "$hostname" | grep -qE '^[a-zA-Z0-9]*$|^[a-zA-Z0-9][a-zA-Z0-9_\-]*[a-zA-Z0-9]$'; then
+    return 1
+  fi
+  return 0
 }
 
 # validates whether file exist
 validate_file_exists() {
+  file_path="$1"
+
+  # checks variable is unset
+  if [ -z "$file_path" ]; then
+    echo "file path variable is not set"
+    return 1
+  fi
+
+  # checks if file exists
+  if [ ! -f "$file_path" ]; then
+    echo "file does not exist"
+    return 1
+  fi
 
+  return 0
 }
 
 validate_ip "$LISTEN_IP"
@@ -72,4 +103,4 @@ fi
 echo "Running Monitoring Service"
 umask 0027
 cd /usr/app || exit
-python run.py
+python run.py
\ No newline at end of file
-- 
2.16.6